Add Lava RPC Endpoints to Mainnet Beta and Mocha Testnet Documentation #1856
Conversation
WalkthroughThis pull request updates documentation for Celestia's network endpoints by adding new community RPC endpoints. For the Mainnet Beta, a new gRPC endpoint Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
how-to-guides/mainnet.md(2 hunks)how-to-guides/mocha-testnet.md(2 hunks)
🔇 Additional comments (2)
how-to-guides/mocha-testnet.md (1)
178-187: LGTM! Consistent endpoint namingThe new Lava endpoints follow a consistent naming pattern with the 'celestiam' prefix for the Mocha testnet, making it clear these are testnet endpoints.
how-to-guides/mainnet.md (1)
175-176: LGTM! Consistent endpoint namingThe new Lava endpoints follow a consistent naming pattern with the 'celestia' prefix for mainnet, making it clear these are mainnet endpoints.
Also applies to: 197-198
| @@ -149,6 +149,7 @@ The default port is 1317. | |||
| - [https://celestia-testnet-api.itrocket.net](https://celestia-testnet-api.itrocket.net) | |||
| - [https://api-celestia-testnet.cryptech.com.ua](https://api-celestia-testnet.cryptech.com.ua) | |||
| - [https://celestia-t-api.noders.services](https://celestia-t-api.noders.services) | |||
| - [http://celestiam.rest.lava.build](http://celestiam.rest.lava.build) | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider using HTTPS for the API endpoint
The API endpoint is using HTTP which is less secure. Consider using HTTPS instead for enhanced security.
- - [http://celestiam.rest.lava.build](http://celestiam.rest.lava.build)
+ - [https://celestiam.rest.lava.build](https://celestiam.rest.lava.build)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [http://celestiam.rest.lava.build](http://celestiam.rest.lava.build) | |
| - [https://celestiam.rest.lava.build](https://celestiam.rest.lava.build) |
| - `celestia.grpc.lava.build:443` | ||
|
|
There was a problem hiding this comment.
💡 Codebase verification
Missing JSON-RPC and Tendermint RPC endpoints confirmed
The review comment is correct. The mainnet documentation is missing the following Lava endpoints:
celestia.jsonrpc.lava.buildcelestia.tendermintrpc.lava.build
🔗 Analysis chain
Missing JSON-RPC and Tendermint RPC endpoints
According to the PR objectives, JSON-RPC and Tendermint RPC endpoints should be added for both networks. These endpoints are missing for the mainnet:
celestia.jsonrpc.lava.buildcelestia.tendermintrpc.lava.build
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify if sections for JSON-RPC and Tendermint RPC endpoints exist in the file
rg -i "json-rpc|tendermint rpc" how-to-guides/mainnet.md
Length of output: 58
Script:
#!/bin/bash
# Get the content of mainnet.md and testnet.md if exists
echo "=== Content of mainnet.md ==="
cat how-to-guides/mainnet.md
echo -e "\n=== Searching for endpoint-related content in testnet docs ==="
fd testnet.md --exec cat {}
echo -e "\n=== Searching for any endpoint references ==="
rg -i "endpoint|rpc|\.build" how-to-guides/
Length of output: 66917
Script:
#!/bin/bash
# Search specifically for jsonrpc and tendermintrpc patterns in mainnet.md
echo "=== Searching for JSON-RPC and Tendermint RPC endpoints ==="
rg -i "jsonrpc\.lava\.build|tendermintrpc\.lava\.build" how-to-guides/mainnet.md
echo -e "\n=== Checking if there are dedicated sections for these endpoint types ==="
rg -i "## .*(json-rpc|tendermint rpc).*endpoints" how-to-guides/mainnet.md
Length of output: 451
Add Lava RPC Endpoints to Mainnet Beta and Mocha Testnet Documentation
This pull request updates the documentation for both Mainnet Beta and Mocha Testnet to include new RPC endpoints provided by Lava.
Mainnet Beta
Community JSON-RPC Endpoints
celestia.jsonrpc.lava.build.Community Tendermint RPC Endpoints
celestia.tendermintrpc.lava.build.Community API Endpoints
celestia.rest.lava.buildto the existing list.Community gRPC Endpoints
celestia.grpc.lava.build:443to the existing list.Mocha Testnet
Community JSON-RPC Endpoints
celestiam.jsonrpc.lava.build.Community Tendermint RPC Endpoints
celestiam.tendermintrpc.lava.build.Community API Endpoints
celestiam.rest.lava.buildto the existing list.Community gRPC Endpoints
celestiam.grpc.lava.build:443to the existing list.Summary by CodeRabbit