Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): fix namespace representation in cmd output #3537

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Jun 28, 2024

Partly refs #3335

celestia blob get 1337536 0x42690c204d39600fddd3 IXg+08HV5RsPF3Lle8PH+B2TUGsGUsBiseflxh6wB5E=
{
  "result": {
    "namespace": "0x42690c204d39600fddd3",
    "data": "gm",
    "share_version": 0,
    "commitment": "IXg+08HV5RsPF3Lle8PH+B2TUGsGUsBiseflxh6wB5E=",
    "index": 1
  }
}
celestia blob get 1337536 0x42690c204d39600fddd3 IXg+08HV5RsPF3Lle8PH+B2TUGsGUsBiseflxh6wB5E= --base64=true
{
  "result": {
    "namespace": "AAAAAAAAAAAAAAAAAAAAAAAAAEJpDCBNOWAP3dM=",
    "data": "Z20=",
    "share_version": 0,
    "commitment": "IXg+08HV5RsPF3Lle8PH+B2TUGsGUsBiseflxh6wB5E=",
    "index": 1
  }
}

Current PR fixes namespace representation, so it will be consistent with the passed one. Blob cmds require hex-based namespaces only now.

@vgonkivs vgonkivs requested review from liamsi and jcstein June 28, 2024 09:55
@vgonkivs vgonkivs self-assigned this Jun 28, 2024
@vgonkivs vgonkivs added the kind:fix Attached to bug-fixing PRs label Jun 28, 2024
ramin
ramin previously approved these changes Jun 28, 2024
@vgonkivs vgonkivs added the v0.15.0 Intended for v0.15.0 release label Jun 28, 2024
cristaloleg
cristaloleg previously approved these changes Jun 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.

Project coverage is 44.54%. Comparing base (2469e7a) to head (22f439c).
Report is 132 commits behind head on main.

Files Patch % Lines
nodebuilder/blob/cmd/blob.go 5.88% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3537      +/-   ##
==========================================
- Coverage   44.83%   44.54%   -0.29%     
==========================================
  Files         265      273       +8     
  Lines       14620    15408     +788     
==========================================
+ Hits         6555     6864     +309     
- Misses       7313     7745     +432     
- Partials      752      799      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgonkivs vgonkivs dismissed stale reviews from cristaloleg and ramin via 31f3543 June 28, 2024 10:07
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vgonkivs commitment is still printed in base64 when hex is printed for namespace and string for data, is this intentionally left?

@vgonkivs
Copy link
Member Author

vgonkivs commented Jul 1, 2024

Yes, non-base64 looks weird and it does not work with get methods !x\u003e\ufffd\ufffd\ufffd\ufffd\u001b\u000f\u0017r\ufffd{\ufffd\ufffd\ufffd\u001d\ufffdPk\u0006R\ufffdb\ufffd\ufffd\ufffd\ufffd\u001e\ufffd\u0007\ufffd

@vgonkivs vgonkivs mentioned this pull request Jul 1, 2024
11 tasks
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@renaynay renaynay enabled auto-merge (squash) July 2, 2024 18:06
@ramin ramin requested review from renaynay and removed request for liamsi July 4, 2024 09:34
@renaynay renaynay merged commit 8febc73 into celestiaorg:main Jul 4, 2024
42 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs v0.15.0 Intended for v0.15.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants