test(swamp): pruning FN blob sync #3464
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
commented
Jun 4, 2024
| // spin up 3 pruning FNs, connect | ||
| // spin up 1 LN that syncs historic blobs | ||
| // | ||
| // Steps: |
There was a problem hiding this comment.
Added step numbers to follow in the test code.
| @@ -64,11 +73,7 @@ func TestArchivalBlobSync(t *testing.T) { | |||
| fx.Replace(testAvailWindow), | |||
| ) | |||
|
|
|||
| // stop the archival BN to force LN to have to discover | |||
There was a problem hiding this comment.
Moved this higher where it should be.
| @@ -77,10 +82,12 @@ func TestArchivalBlobSync(t *testing.T) { | |||
| err = archivalFN.Host.Connect(ctx, *host.InfoFromHost(pruningBN.Host)) | |||
| require.NoError(t, err) | |||
|
|
|||
| // step 5. | |||
| const numFNs = 3 | |||
There was a problem hiding this comment.
Extracted as a const.
| i := 1 | ||
| for { | ||
|
|
||
| for i := 1; len(archivalBlobs) < wantBlobs; i++ { |
There was a problem hiding this comment.
We just need to collect wantBlobs here, i is a simple increment that can be done in a loop declaration.
|
|
||
| // Pruning_FN from only archival_FN. | ||
| // | ||
| // Steps: |
There was a problem hiding this comment.
Not sure should there be more steps to verify all logic paths 🤷
|
|
||
| require.NoError(t, <-fillDn) | ||
|
|
||
| type archivalBlob struct { |
There was a problem hiding this comment.
Probably this can be named as a separate step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3444