Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodebuilder/tests: Add more test cases for archival blob/block sync #3444

Open
renaynay opened this issue May 28, 2024 · 2 comments
Open

nodebuilder/tests: Add more test cases for archival blob/block sync #3444

renaynay opened this issue May 28, 2024 · 2 comments
Assignees
Labels
area:storage e2e e2e testing related

Comments

@renaynay
Copy link
Member

  • Pruning_FN can sync from only pruning_FN/BN.
  • Pruning_FN from only archival_FN.
  • Archival_FN from archival_FN. There is a test syncing from archival_BN, which is similar but not the same.
  • LN can manually request archival and recent blobs from ONLY archival_FN.
  • LN can manually request recent blobs from ONLY pruning_FN.
@walldiss
Copy link
Member

walldiss commented Jun 5, 2024

Full list of cases that needs to be covered to ensure pruned/rachival routing works as intended.

  • Archival FN (4)
    • sync outside of sampling window from Archival BN
    • sync outside of sampling window from Archival FN
    • sync inside of sampling window from Archival BN
    • sync inside of sampling window from Archival FN
  • Pruned FN (6)
    • same 4 as Archival FN
    • sync inside of sampling window from Pruned BN
    • sync inside of sampling window from Pruned FN
  • LN (8)
    • sync inside of sampling window from Archival BN
    • sync inside of sampling window from Archival FN
    • sync inside of sampling window from Pruned BN
    • sync inside of sampling window from Pruned FN
    • request data from Archival BN
    • request data from Archival FN
    • request data from Pruned BN
    • request data from Pruned FN

Multiple test cases can easily covered within same test. For example all tests can be covered if cases are grouped by source of data:

  • syncing / requesting from Archival only
  • syncing / requesting from Pruned only

@cristaloleg
Copy link
Contributor

For the future readers:

  • FN means full node
  • BN means bridge node
  • LN means light node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:storage e2e e2e testing related
Projects
None yet
Development

No branches or pull requests

3 participants