chore(deps): bump go version to 1.23.1 #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
requested review from
cmwaters and
staheri14
and removed request for
a team
rootulp
previously approved these changes
Sep 11, 2024
Co-authored-by: Rootul P <[email protected]>
rach-id
force-pushed
the
bump-go-version
branch
from
57f1a99
to
c41c734
Compare
rach-id
force-pushed
the
bump-go-version
branch
from
f827c38
to
8a0e394
Compare
rootulp
previously approved these changes
Sep 11, 2024
I didn't want to do it so in case future contributions are hitting any cases where we should be aware. The current code worked for years without the checks, we can assume it's fine. But new code might need the safe conversions. That's why I left it |
rach-id
force-pushed
the
bump-go-version
branch
from
2dba88a
to
5ec3dfd
Compare
rootulp
approved these changes
Sep 17, 2024
staheri14
reviewed
Sep 17, 2024
| - name: Create a file with all the pkgs | ||
| run: go list ./... > pkgs.txt | ||
| - name: Split pkgs into 4 files | ||
| run: split -d -n l/4 pkgs.txt pkgs.txt.part. | ||
| # cache multiple | ||
| - uses: actions/upload-artifact@v3 | ||
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Just curious to know whether this is also necessary for the Go version upgrade to work? or it is an independent change?
There was a problem hiding this comment.
All are necessary because they don't support the new version of go, unless I am missing something
staheri14
approved these changes
Sep 17, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps go version to 1.23.1