Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix go doc function name #1452

Open
wants to merge 4 commits into
base: v0.34.x-celestia
Choose a base branch
from

Conversation

luozexuan
Copy link

Description

fix some function names


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use
    unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@luozexuan luozexuan requested a review from a team as a code owner August 9, 2024 15:49
@luozexuan luozexuan requested review from cmwaters and staheri14 and removed request for a team August 9, 2024 15:49
rootulp
rootulp previously approved these changes Aug 9, 2024
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be possible to upstream some of these fixes to https://github.com/cometbft/cometbft

@rootulp rootulp enabled auto-merge (squash) August 9, 2024 17:51
Signed-off-by: luozexuan <[email protected]>
auto-merge was automatically disabled August 15, 2024 08:48

Head branch was pushed to by a user without write access

@luozexuan
Copy link
Author

It may be possible to upstream some of these fixes to https://github.com/cometbft/cometbft

Thank you for your prompt. I have checked the comet repository and found that the names of the other two methods have been modified

@rootulp rootulp enabled auto-merge (squash) August 15, 2024 12:58
@rootulp rootulp changed the title chore: fix some function names chore: fix go doc function name Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants