Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve and test versioned ibc module #3500

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

ninabarbakadze
Copy link
Member

Overview

Fixes #3406

@ninabarbakadze ninabarbakadze marked this pull request as ready for review May 22, 2024 12:46
@ninabarbakadze ninabarbakadze requested a review from a team as a code owner May 22, 2024 12:46
@ninabarbakadze ninabarbakadze requested review from ramin and evan-forbes and removed request for a team May 22, 2024 12:46
Copy link
Contributor

coderabbitai bot commented May 22, 2024

Walkthrough

Walkthrough

The recent changes introduce a new version-checking mechanism in the VersionedIBCModule to centralize and simplify version validation across various IBC-related methods. Additionally, mock implementations for the IBCModule interface were generated for testing purposes, and a comprehensive test suite was added to ensure the versioning functionality operates correctly.

Changes

Files/Paths Change Summary
.../mocks/versioned_ibc.go Generated mock implementations for IBCModule interface using MockGen.
.../module/versioned_ibc_module.go Refactored methods to use a centralized isVersionSupported method for version checks.
.../module/versioned_ibc_module.go Added a new method isVersionSupported to centralize version check logic.
.../module/versioned_ibc_module_test.go Introduced a test suite to verify VersionedIBCModule behavior based on different app versions.

Assessment against linked issues

Objective Addressed Explanation
Write unit tests for the new versioned IBC module (#3406)
Ensure versioning functionality works as expected (#3406)
Centralize version check logic in VersionedIBCModule methods

Recent Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between ec6f9c2 and 845487b.
Files selected for processing (1)
  • app/module/versioned_ibc_module_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/module/versioned_ibc_module_test.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ninabarbakadze ninabarbakadze added the WS: V2 ✌️ lemongrass hardfork related label May 22, 2024
@celestia-bot celestia-bot requested a review from a team May 22, 2024 12:54
@@ -37,8 +37,7 @@ func (v *VersionedIBCModule) OnChanOpenInit(
counterparty channeltypes.Counterparty,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the file rename 👍

@rootulp rootulp removed the request for review from ramin May 22, 2024 15:00
@ninabarbakadze ninabarbakadze merged commit 82a257d into main May 22, 2024
32 of 33 checks passed
@ninabarbakadze ninabarbakadze deleted the nina/ibc-test branch May 22, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS: V2 ✌️ lemongrass hardfork related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for the new versioned ibc module
3 participants