fix: e2e tests #3487
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: test-e2e | ||
|
|
||
| on: | ||
| workflow_call: | ||
| secrets: | ||
| KNUU_KUBECONFIG_FILE: | ||
| required: true | ||
|
|
||
| jobs: | ||
| test-e2e: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| ref: main | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: "go.mod" | ||
| - name: Setup kubeconfig | ||
| env: | ||
| KUBECONFIG_FILE: ${{ secrets.KNUU_KUBECONFIG_FILE }} | ||
| run: | | ||
| mkdir -p $HOME/.kube | ||
| echo "${KUBECONFIG_FILE}" > $HOME/.kube/config | ||
| - name: Run e2e tests | ||
| run: make test-e2e |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "fmt" | ||
| "log" | ||
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/celestiaorg/celestia-app/v2/app" | ||
| "github.com/celestiaorg/celestia-app/v2/app/encoding" | ||
| v1 "github.com/celestiaorg/celestia-app/v2/pkg/appconsts/v1" | ||
| v2 "github.com/celestiaorg/celestia-app/v2/pkg/appconsts/v2" | ||
| "github.com/celestiaorg/celestia-app/v2/test/e2e/testnet" | ||
| "github.com/celestiaorg/celestia-app/v2/test/txsim" | ||
| "github.com/celestiaorg/knuu/pkg/knuu" | ||
| "github.com/tendermint/tendermint/rpc/client/http" | ||
| ) | ||
|
|
||
| func MajorUpgradeToV2(logger *log.Logger) error { | ||
ninabarbakadze marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| latestVersion, err := testnet.GetLatestVersion() | ||
| testnet.NoError("failed to get latest version", err) | ||
|
|
||
| logger.Println("Running major upgrade to v2 test", "version", latestVersion) | ||
|
|
||
| numNodes := 4 | ||
| upgradeHeight := int64(12) | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer cancel() | ||
|
|
||
| logger.Println("Creating testnet") | ||
| testNet, err := testnet.New("runMajorUpgradeToV2", seed, nil, "test") | ||
| testnet.NoError("failed to create testnet", err) | ||
|
|
||
| defer testNet.Cleanup() | ||
|
|
||
| testNet.SetConsensusParams(app.DefaultInitialConsensusParams()) | ||
|
|
||
| preloader, err := knuu.NewPreloader() | ||
| testnet.NoError("failed to create preloader", err) | ||
|
|
||
| defer func() { _ = preloader.EmptyImages() }() | ||
| testnet.NoError("failed to add image", preloader.AddImage(testnet.DockerImageName(latestVersion))) | ||
|
|
||
| logger.Println("Creating genesis nodes") | ||
| for i := 0; i < numNodes; i++ { | ||
| err := testNet.CreateGenesisNode(latestVersion, 10000000, upgradeHeight, testnet.DefaultResources) | ||
| testnet.NoError("failed to create genesis node", err) | ||
| } | ||
|
|
||
| kr, err := testNet.CreateAccount("alice", 1e12, "") | ||
| testnet.NoError("failed to create account", err) | ||
|
There was a problem hiding this comment. nit for future: if we move files, ideally (I haven't always done this!) we only move them and not change anything to reduce the effort to see what actually changed. in this case it looked like it was just some comments There was a problem hiding this comment. yeah I tend to agree but since it was only minor changes I applied suggestions |
||
|
|
||
| logger.Println("Setting up testnet") | ||
| testnet.NoError("Failed to setup testnet", testNet.Setup()) | ||
| logger.Println("Starting testnet") | ||
| testnet.NoError("Failed to start testnet", testNet.Start()) | ||
|
|
||
| errCh := make(chan error) | ||
| encCfg := encoding.MakeConfig(app.ModuleEncodingRegisters...) | ||
| opts := txsim.DefaultOptions().WithSeed(seed).SuppressLogs() | ||
| sequences := txsim.NewBlobSequence(txsim.NewRange(200, 4000), txsim.NewRange(1, 3)).Clone(5) | ||
| sequences = append(sequences, txsim.NewSendSequence(4, 1000, 100).Clone(5)...) | ||
| go func() { | ||
| errCh <- txsim.Run(ctx, testNet.GRPCEndpoints()[0], kr, encCfg, opts, sequences...) | ||
| }() | ||
|
|
||
| heightBefore := upgradeHeight - 1 | ||
| for i := 0; i < numNodes; i++ { | ||
| client, err := testNet.Node(i).Client() | ||
| testnet.NoError("failed to get client", err) | ||
|
|
||
| testnet.NoError("failed to wait for height", waitForHeight(testNet, testNet.Node(i), upgradeHeight, time.Minute)) | ||
|
|
||
| resp, err := client.Header(ctx, &heightBefore) | ||
| testnet.NoError("failed to get header", err) | ||
| logger.Println("Node", i, "is running on version", resp.Header.Version.App) | ||
| if resp.Header.Version.App != v1.Version { | ||
| return fmt.Errorf("version mismatch before upgrade: expected %d, got %d", v1.Version, resp.Header.Version.App) | ||
| } | ||
|
|
||
| resp, err = client.Header(ctx, &upgradeHeight) | ||
| testnet.NoError("failed to get header", err) | ||
| if resp.Header.Version.App != v2.Version { | ||
| return fmt.Errorf("version mismatch after upgrade: expected %d, got %d", v2.Version, resp.Header.Version.App) | ||
| } | ||
| } | ||
|
|
||
| // end txsim | ||
| cancel() | ||
|
|
||
| err = <-errCh | ||
| if !strings.Contains(err.Error(), context.Canceled.Error()) { | ||
| return fmt.Errorf("expected context.Canceled error, got: %w", err) | ||
| } | ||
| return nil | ||
ninabarbakadze marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| func getHeight(ctx context.Context, client *http.HTTP, period time.Duration) (int64, error) { | ||
| timer := time.NewTimer(period) | ||
| ticker := time.NewTicker(100 * time.Millisecond) | ||
| for { | ||
| select { | ||
| case <-timer.C: | ||
| return 0, fmt.Errorf("failed to get height after %.2f seconds", period.Seconds()) | ||
| case <-ticker.C: | ||
| status, err := client.Status(ctx) | ||
| if err == nil { | ||
| return status.SyncInfo.LatestBlockHeight, nil | ||
| } | ||
| if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) { | ||
| return 0, err | ||
| } | ||
| } | ||
| } | ||
| } | ||
ninabarbakadze marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| func waitForHeight(testnet *testnet.Testnet, node *testnet.Node, height int64, period time.Duration) error { | ||
| timer := time.NewTimer(period) | ||
| ticker := time.NewTicker(100 * time.Millisecond) | ||
| for { | ||
| select { | ||
| case <-timer.C: | ||
| return fmt.Errorf("failed to reach height %d in %.2f seconds", height, period.Seconds()) | ||
| case <-ticker.C: | ||
| executor, err := testnet.GetExecutor() | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get executor: %w", err) | ||
| } | ||
| currentHeight, err := node.GetHeight(executor) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if currentHeight >= height { | ||
| return nil | ||
| } | ||
| } | ||
| } | ||
| } | ||
ninabarbakadze marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Does this need to be printed? Doesn't each test usually print their names upon start?