-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update sdk and tm (backport #3093) #3098
Conversation
Uses v1.33.0 for tendermint and v1.20.1 for the SDK (cherry picked from commit 738bb9f) # Conflicts: # go.mod # go.sum # go.work.sum # test/testground/go.mod # test/testground/go.sum
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Question for @cmwaters: why do we need to backport this cosmos-sdk and tendermint bump? I'm not opposed just curious. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of failing CI tasks so I think this is still WIP
test is failing on TestMaxBlockSize here |
No we don't have to. I don't think there's anything urgent. There are some nice changes like fixing some bug in the CAT pool and adding a bunch of metrics |
Are we planning on cutting a new v1.x release after this merges? In the past we've discussed only backporting fixes |
This is an automatic backport of pull request #3093 done by Mergify.
Cherry-pick of 738bb9f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com