ci: add support for go vulncheck #2744
Conversation
rach-id
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2744 +/- ##
=======================================
Coverage 19.62% 19.62%
=======================================
Files 139 139
Lines 16999 16999
=======================================
Hits 3336 3336
Misses 13341 13341
Partials 322 322 |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| @@ -69,3 +71,26 @@ jobs: | |||
| uses: github/codeql-action/analyze@v2 | |||
| with: | |||
| category: "/language:${{matrix.language}}" | |||
|
|
|||
| govulnech: | |||
There was a problem hiding this comment.
[typo]
| govulnech: | |
| govulncheck: |
| @@ -9,9 +9,11 @@ | |||
| # the `language` matrix defined below to confirm you have the correct set of | |||
| # supported CodeQL languages. | |||
| # | |||
There was a problem hiding this comment.
[optional] if we repurpose this file, IMO we can remove the comment boilerplate from the top of the file.
Alternatively: we keep the boilerplate and move govulncheck to a new file.
There was a problem hiding this comment.
sure, good idea 👍
Originally, I opened this PR to test vulncheck and see what the results it will give and if it's worth it to add it next to codeQL
There was a problem hiding this comment.
I expect go vulncheck will become a best practice for repos so I think we should add it.
Closes #2968 Supersedes #2744 ## Description - CI workflow is inspired by https://github.com/celestiaorg/celestia-core/blob/main/.github/workflows/govulncheck.yml - Bumped to Go 1.21.5 to resolve some vulnerabilities identified by govulncheck
|
Can close b/c #2969 merged |
add auth, blob, blobstream, and consensus governance param tests add governance params tests for distribution add tests for modifying gov params add tests for modifying ibc params add tests for modifying slashing params add tests for modifying staking params ci: remove version_bump job (celestiaorg#2962) Closes celestiaorg#2884 - Remove the version_bump and branch_name jobs - Extract the goreleaser jobs to a new file Can still create a release. See https://github.com/rootulp/celestia-app/actions/runs/7324051789/job/19947265102 docs: add column for governance modifiable params in resource_pricing (celestiaorg#2974) Addresses celestiaorg#2966 by using the governance modifiable params tests in PR All four of the params are modifiable by governance, which matches the specs in [params.md](https://github.com/celestiaorg/celestia-app/blob/main/specs/src/specs/params.md). - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords chore: remove unnecessary conversions (celestiaorg#2975) Use linter to detect unnecessary type conversions https://github.com/mdempsky/unconvert ci: enable govulncheck (celestiaorg#2969) Closes celestiaorg#2968 Supersedes celestiaorg#2744 - CI workflow is inspired by https://github.com/celestiaorg/celestia-core/blob/main/.github/workflows/govulncheck.yml - Bumped to Go 1.21.5 to resolve some vulnerabilities identified by govulncheck improve naming of governance params test suite fix govHandler and remove test for an unmodifiable param. remove unneeded minter setup
Closes celestiaorg/celestia-app#2968 Supersedes celestiaorg/celestia-app#2744 ## Description - CI workflow is inspired by https://github.com/celestiaorg/celestia-core/blob/main/.github/workflows/govulncheck.yml - Bumped to Go 1.21.5 to resolve some vulnerabilities identified by govulncheck
Overview
Checklist