-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build manually the app binary for codeql #2645
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2645 +/- ##
=======================================
Coverage 20.62% 20.62%
=======================================
Files 133 133
Lines 15345 15345
=======================================
Hits 3165 3165
Misses 11877 11877
Partials 303 303 |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/celestiaorg/celestia-app/security/code-scanning?query=pr%3A2645+is%3Aopen shows errors so I think CodeQL is working after this PR.
It's not immediately clear from the PR description what was broken with CodeQL before this PR but I'm guessing the auto build here didn't work. Can you please confirm @sweexordious ?
yes, I'll update the description |
Overview
Currently, the auto builder doesn't support go version 1.21.1, and it expects the binary to be built using
make
instead ofmake build
. This PR installs the right version of go manually and builds the binary.Checklist