Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build manually the app binary for codeql #2645

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Oct 10, 2023

Overview

Currently, the auto builder doesn't support go version 1.21.1, and it expects the binary to be built using make instead of make build. This PR installs the right version of go manually and builds the binary.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id marked this pull request as draft October 10, 2023 10:30
@celestia-bot celestia-bot requested a review from a team October 10, 2023 10:30
@rach-id rach-id self-assigned this Oct 10, 2023
@rach-id rach-id added the CI item that directly relates to or modify the CI label Oct 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #2645 (e1c2cfb) into main (3722119) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2645   +/-   ##
=======================================
  Coverage   20.62%   20.62%           
=======================================
  Files         133      133           
  Lines       15345    15345           
=======================================
  Hits         3165     3165           
  Misses      11877    11877           
  Partials      303      303           

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@rach-id rach-id marked this pull request as ready for review October 10, 2023 11:00
@rach-id rach-id changed the title chore: build manually the app binary for codeql fix: build manually the app binary for codeql Oct 10, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/celestiaorg/celestia-app/security/code-scanning?query=pr%3A2645+is%3Aopen shows errors so I think CodeQL is working after this PR.

It's not immediately clear from the PR description what was broken with CodeQL before this PR but I'm guessing the auto build here didn't work. Can you please confirm @sweexordious ?

@rach-id
Copy link
Member Author

rach-id commented Oct 10, 2023

yes, I'll update the description

@rach-id rach-id merged commit 4882c58 into main Oct 11, 2023
30 checks passed
@rach-id rach-id deleted the SweeXordious-patch-1 branch October 11, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI item that directly relates to or modify the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants