Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update min commission rate #2491

Closed

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 13, 2023

Closes #2480

TBH we can close this PR if we plan on merging #2417 soon.

@rootulp rootulp added documentation Improvements or additions to documentation specs directly relevant to the specs labels Sep 13, 2023
@rootulp rootulp added this to the Mainnet milestone Sep 13, 2023
@rootulp rootulp self-assigned this Sep 13, 2023
@celestia-bot celestia-bot requested a review from a team September 13, 2023 18:30
@codecov-commenter
Copy link

Codecov Report

Merging #2491 (20e9f27) into main (0012451) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2491   +/-   ##
=======================================
  Coverage   20.62%   20.62%           
=======================================
  Files         131      131           
  Lines       15275    15275           
=======================================
  Hits         3151     3151           
  Misses      11821    11821           
  Partials      303      303           

@rootulp
Copy link
Collaborator Author

rootulp commented Sep 13, 2023

My impression is we're merging #2417 soon so closing this.

@rootulp rootulp closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation specs directly relevant to the specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is MinCommissionRate correct?
2 participants