Makefile: simpily ledger build tags #2449
Conversation
|
|
|
||
| # process linker flags | ||
| ldflags = -X github.com/cosmos/cosmos-sdk/version.Name=celestia-app \ | ||
| -X github.com/cosmos/cosmos-sdk/version.AppName=celestia-appd \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Version=$(VERSION) \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) \ | ||
| -X "github.com/cosmos/cosmos-sdk/version.BuildTags=$(build_tags_comma_sep)" |
There was a problem hiding this comment.
Removing this line had zero impact on ledger it seemed. If someone knows why this line is needed, I'm happy to add it back in.
There was a problem hiding this comment.
It appears to have been added in #360 but build_tags_comma_sep wasn't defined in that PR so it seems like it was a no-op when first introduced.
|
|
||
| # process linker flags | ||
| ldflags = -X github.com/cosmos/cosmos-sdk/version.Name=celestia-app \ | ||
| -X github.com/cosmos/cosmos-sdk/version.AppName=celestia-appd \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Version=$(VERSION) \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) \ | ||
| -X "github.com/cosmos/cosmos-sdk/version.BuildTags=$(build_tags_comma_sep)" | ||
| ldflags += $(LDFLAGS) |
There was a problem hiding this comment.
LDFLAGS isn't defined anywhere so this line is a no-op.
MSevey
requested review from
liamsi,
adlerjohn,
evan-forbes,
rootulp and
cmwaters
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2449 +/- ##
=======================================
Coverage 20.61% 20.61%
=======================================
Files 131 131
Lines 15270 15270
=======================================
Hits 3148 3148
Misses 11820 11820
Partials 302 302 📢 Have feedback on the report? Share it here. |
There was a problem hiding this comment.
Thanks for the clean up!
[nit] PR title could use a conventional commit prefix so that the squashed commit has a conventional commit prefix so that the auto generated release notes are easy to scan and identify if the next release should be a major, minor, or patch release.
|
|
||
| # process linker flags | ||
| ldflags = -X github.com/cosmos/cosmos-sdk/version.Name=celestia-app \ | ||
| -X github.com/cosmos/cosmos-sdk/version.AppName=celestia-appd \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Version=$(VERSION) \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) \ | ||
| -X "github.com/cosmos/cosmos-sdk/version.BuildTags=$(build_tags_comma_sep)" |
There was a problem hiding this comment.
It appears to have been added in #360 but build_tags_comma_sep wasn't defined in that PR so it seems like it was a no-op when first introduced.
rootulp
added
the
backport:v1.x
In the process of working on the `goreleaser` PR I discovered that how we are building the `BUILD_TAGS` is overly verbose and unnecessary. Ultimately we are just trying to add `ledger` to `-tags`. Hardcoding it and adding a note in the README for the 2 distributions that aren't supported seemed easier to maintain. (cherry picked from commit 67241f9) # Conflicts: # specs/src/SUMMARY.md
This is an automatic backport of pull request #2449 done by [Mergify](https://mergify.com). Closes #2597 --------- Co-authored-by: Matthew Sevey <[email protected]> Co-authored-by: Rootul P <[email protected]>
In the process of working on the
goreleaserPR I discovered that how we are building theBUILD_TAGSis overly verbose and unnecessary.Ultimately we are just trying to add
ledgerto-tags. Hardcoding it and adding a note in the README for the 2 distributions that aren't supported seemed easier to maintain.