docs: add default params to the spec #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
specs
evan-forbes
requested review from
liamsi,
adlerjohn,
rootulp and
cmwaters
as code owners
evan-forbes
added
the
backport:v1.x
|
evan-forbes
commented
Sep 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #2416 +/- ##
=======================================
Coverage 20.61% 20.61%
=======================================
Files 131 131
Lines 15270 15270
=======================================
Hits 3148 3148
Misses 11820 11820
Partials 302 302 |
adlerjohn
reviewed
Sep 4, 2023
Co-authored-by: John Adler <[email protected]>
5 tasks
liamsi
reviewed
Sep 4, 2023
liamsi
reviewed
Sep 4, 2023
liamsi
reviewed
Sep 4, 2023
liamsi
reviewed
Sep 4, 2023
liamsi
reviewed
Sep 4, 2023
liamsi
reviewed
Sep 4, 2023
liamsi
reviewed
Sep 4, 2023
liamsi
reviewed
Sep 4, 2023
adlerjohn
approved these changes
Sep 4, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
## Overview note that the descriptions have been updated from what was in notion to be consistent and correct a few minor nuances closes #2413 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords --------- Co-authored-by: John Adler <[email protected]> (cherry picked from commit 4e62d2d) # Conflicts: # specs/src/README.md # specs/src/SUMMARY.md
evan-forbes
added a commit
that referenced
this pull request
Sep 5, 2023
This is an automatic backport of pull request #2416 done by [Mergify](https://mergify.com). Cherry-pick of 4e62d2d has failed: ``` On branch mergify/bp/v1.x/pr-2416 Your branch is up to date with 'origin/v1.x'. You are currently cherry-picking commit 4e62d2d. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: new file: specs/src/specs/params.md Unmerged paths: (use "git add <file>..." to mark resolution) both modified: specs/src/README.md both modified: specs/src/SUMMARY.md ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Evan Forbes <[email protected]> Co-authored-by: evan-forbes <[email protected]>
liamsi
reviewed
Sep 11, 2023
evan-forbes
added a commit
that referenced
this pull request
Sep 14, 2023
## Overview minor update to the defaults to match #2416. ofc, these are not consensus breaking as they're just changes to the defaults. This saves us from having to manually change this for mainnet or mocha ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Rootul P <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
## Overview minor update to the defaults to match #2416. ofc, these are not consensus breaking as they're just changes to the defaults. This saves us from having to manually change this for mainnet or mocha ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Rootul P <[email protected]> (cherry picked from commit 9fa9fbf) # Conflicts: # app/default_overrides.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
note that the descriptions have been updated from what was in notion to be consistent and correct a few minor nuances
closes #2413
Checklist