Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(x/mint)!: shorten keys #2405

Closed
wants to merge 1 commit into from

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 31, 2023

Closes #2497
Closes #2498

@rootulp rootulp added x/mint backport:v1.x PR will be backported automatically to the v1.x branch upon merging labels Aug 31, 2023
@rootulp rootulp added this to the Mainnet milestone Aug 31, 2023
@rootulp rootulp self-assigned this Aug 31, 2023
@celestia-bot celestia-bot requested a review from a team August 31, 2023 20:34
@codecov-commenter
Copy link

Codecov Report

Merging #2405 (793113c) into main (58c1e4e) will increase coverage by 20.60%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main    #2405       +/-   ##
=========================================
+ Coverage      0   20.60%   +20.60%     
=========================================
  Files         0      131      +131     
  Lines         0    15276    +15276     
=========================================
+ Hits          0     3148     +3148     
- Misses        0    11826    +11826     
- Partials      0      302      +302     

see 131 files with indirect coverage changes

@rootulp
Copy link
Collaborator Author

rootulp commented Sep 13, 2023

Note this PR is breaking and we haven't come to a decision on whether we include it in v1.0.0 or close it and never do it.

@cmwaters
Copy link
Contributor

It's breaking but I don't see much risk in making that change if we already plan on making a breaking change. At the same time, I don't think there's too much to gain

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should merge this without either deciding that we want to hardfork the testnets and include this in v1, or add a migration script

@rootulp
Copy link
Collaborator Author

rootulp commented Sep 21, 2023

+1 we can re-open later if we want this for v2 but based on our last call, it's not making it into v1.

@rootulp rootulp closed this Sep 21, 2023
@rootulp rootulp deleted the rp/shorten-mint-keys branch September 21, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mint module: Shortening of KeyGenesisTime Mint module: Shortening of KeyMinter
4 participants