Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add block validity rules specs (backport #1966) #2386

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 30, 2023

This is an automatic backport of pull request #1966 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

## Overview

Figured we could at least use this as a place holder as a high level
summary of celestia-app, and to point to all the other portions of the
application.

part of and closes
#743
part of #650

[rendered](https://github.com/celestiaorg/celestia-app/blob/b44960898f59ea3ed86430828606cdc72107a0be/specs/src/specs/block_validity_rules.md)

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

---------

Co-authored-by: Callum Waters <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Sanaz Taheri <[email protected]>
(cherry picked from commit 5bcf4ad)
@github-actions github-actions bot added the bot item was created by a bot label Aug 30, 2023
@github-actions
Copy link

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/celestia-app/pr-preview/pr-2386/
on branch gh-pages at 2023-08-30 15:07 UTC

@celestia-bot celestia-bot requested a review from a team August 30, 2023 15:07
@rootulp
Copy link
Collaborator

rootulp commented Aug 30, 2023

wow today I learned you can add the backport v1.x label to PRs that have already merged and mergify will open a PR for you. I mistakenly thought mergify would only work if the label was applied prior to PR merge.

Anyway closing this as a duplicate of #2384

@rootulp rootulp closed this Aug 30, 2023
@rootulp rootulp deleted the mergify/bp/v1.x/pr-1966 branch August 30, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants