Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix namespace rules in x/blob/README.md #2368

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 27, 2023

Closes #2350

@rootulp rootulp added the documentation Improvements or additions to documentation label Aug 27, 2023
@rootulp rootulp self-assigned this Aug 27, 2023
@rootulp rootulp requested a review from cmwaters as a code owner August 27, 2023 16:16
@rootulp rootulp added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Aug 27, 2023
@celestia-bot celestia-bot requested a review from a team August 27, 2023 16:16
@rootulp rootulp enabled auto-merge (squash) August 27, 2023 16:16
@codecov-commenter
Copy link

Codecov Report

Merging #2368 (b35cc1c) into main (c90e61d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2368   +/-   ##
=======================================
  Coverage   20.65%   20.65%           
=======================================
  Files         131      131           
  Lines       15241    15241           
=======================================
  Hits         3148     3148           
  Misses      11791    11791           
  Partials      302      302           

Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rootulp rootulp merged commit 55f4360 into celestiaorg:main Aug 28, 2023
21 checks passed
mergify bot pushed a commit that referenced this pull request Aug 28, 2023
Closes #2350

(cherry picked from commit 55f4360)

# Conflicts:
#	x/blob/README.md
@rootulp rootulp deleted the rootulp/issue2350 branch August 28, 2023 18:03
rootulp added a commit that referenced this pull request Aug 28, 2023
This is an automatic backport of pull request #2368 done by
[Mergify](https://mergify.com).
Cherry-pick of 55f4360 has failed:
```
On branch mergify/bp/v1.x/pr-2368
Your branch is up to date with 'origin/v1.x'.

You are currently cherry-picking commit 55f4360.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x/blob/README.md

no changes added to commit (use "git add" and/or "git commit -a")
```


To fix up this pull request, you can check it out locally. See
documentation:
https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

---------

Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/blob/README.md contains outdated reserved namespace rules
4 participants