refactor!: remove builder return param from init #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
refactor
Codecov Report
@@ Coverage Diff @@
## main #2165 +/- ##
==========================================
+ Coverage 24.41% 24.45% +0.04%
==========================================
Files 126 126
Lines 14300 14301 +1
==========================================
+ Hits 3491 3498 +7
+ Misses 10448 10444 -4
+ Partials 361 359 -2
|
evan-forbes
previously approved these changes
Jul 26, 2023
Don't remember the rational behind it, I checked the code and probably the reason does not exist any more. So we can merge the two functions. |
mojtaba-esk
requested changes
Jul 26, 2023
mojtaba-esk
previously approved these changes
Jul 26, 2023
| @@ -318,3 +311,10 @@ func TestShareBuilderImportRawData(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| // mustNewBuilder returns a new builder with the given parameters. It fails the test if an error is encountered. | |||
| func mustNewBuilder(t *testing.T, ns appns.Namespace, shareVersion uint8, isFirstShare bool) *Builder { | |||
mojtaba-esk
approved these changes
Jul 26, 2023
cmwaters
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2157
A separate
Init()function seems kinda like an anti pattern. If it must always be called afterNewBuilder, why doesn'tNewBuildercall it? @mojtaba-esk