Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blob size upper bound #2152

Closed
wants to merge 6 commits into from

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 22, 2023

v0 implementation of #2108
In order to resolve the TODOs, we need to make celestia-node aware of the governance params.

cc: @vgonkivs

@rootulp rootulp self-assigned this Jul 22, 2023
@rootulp rootulp changed the title feat: MaxBlobSize feat: blob size upper bound Jul 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2152 (30277ad) into main (b77ac63) will increase coverage by 0.11%.
Report is 21 commits behind head on main.
The diff coverage is 21.05%.

@@            Coverage Diff             @@
##             main    #2152      +/-   ##
==========================================
+ Coverage   24.28%   24.39%   +0.11%     
==========================================
  Files         125      127       +2     
  Lines       14248    14319      +71     
==========================================
+ Hits         3460     3493      +33     
- Misses      10432    10466      +34     
- Partials      356      360       +4     
Files Changed Coverage Δ
x/blob/types/blob_size_upper_bound.go 0.00% <0.00%> (ø)
x/blob/types/payforblob.go 69.54% <0.00%> (-4.02%) ⬇️
x/mint/types/constants.go 100.00% <ø> (ø)
test/txsim/blob.go 80.00% <100.00%> (-0.65%) ⬇️
x/blob/ante/ante.go 85.00% <100.00%> (-3.47%) ⬇️
x/blob/keeper/keeper.go 80.00% <100.00%> (-2.76%) ⬇️

... and 7 files with indirect coverage changes

@rootulp rootulp marked this pull request as ready for review July 28, 2023 15:16
@MSevey MSevey requested a review from a team July 28, 2023 15:20
@rootulp
Copy link
Collaborator Author

rootulp commented Jul 28, 2023

I had a synchronous call w/ @evan-forbes and this PR may be obsolete if we add stateless validation to PFB transactions.

@rootulp rootulp marked this pull request as draft July 28, 2023 15:56
@rootulp rootulp closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants