Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add block validity rules specs #1966
docs: add block validity rules specs #1966
Changes from 5 commits
134b2b4
0555466
f3a5470
51411fa
07c2678
8173c9c
b449608
d0329fd
069bbd7
8a5a7d1
f8660a7
b6ebd26
4cac7a4
c3e19fe
57380e7
f72be81
550e4f5
b36dcc4
89c03ac
88a3ac7
27209c8
9dca098
71cac1e
7ac6ec3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess checking the validity of the transaction nonces goes under the CometBFT validity rules, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question! I don't think the ante handlers are really specified sufficiently anywhere, especially our usage of them, so I added #2044
that might involve updating the above! the reasoning behind saying "all remaining transactions types do not have to be valid" were these lines
celestia-app/app/process_proposal.go
Lines 55 to 61 in 65046dd
in the past, the rules were that validators could include invalid transactions in the block. It's very reasonable to see this as incorrect now since the most recent fix to use the entire antehandler instead of only incrementing the nonce!
celestia-app/app/process_proposal.go
Lines 72 to 79 in 65046dd
we might want to say something along the lines of "random tx data is permitted, but decodable sdk.Txs must pass all antehandler checks in order for the block to be valid".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linked this convo as part of that issue to ensure we address this specifically