Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/blob/README.md contains outdated reserved namespace rules #2350

Closed
rootulp opened this issue Aug 24, 2023 · 1 comment · Fixed by #2368
Closed

x/blob/README.md contains outdated reserved namespace rules #2350

rootulp opened this issue Aug 24, 2023 · 1 comment · Fixed by #2368
Assignees
@rootulp
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@rootulp
Copy link
Collaborator

rootulp commented Aug 24, 2023

Context

celestia-app/x/blob/README.md

Lines 147 to 150 in 7f97788

1. The namespace is lexicographically greater than the [MAX_RESERVED_NAMESPACE](../../specs/src/specs/consensus.md#constants).
1. The namespace is not the
[TAIL_PADDING_NAMESPACE](../../specs/src/specs/consensus.md#constants)
or [PARITY_SHARE_NAMESPACE](../../specs/src/specs/consensus.md#constants).

Problem

After #2257 more namespaces were reserved

Proposal

Update this section of the README to state that the namespace must be a valid blob namespace (i.e. not reserved for protocol use).
@rootulp rootulp added documentation Improvements or additions to documentation good first issue Good for newcomers labels Aug 24, 2023
@Vikramop
Copy link
Contributor

Can u like explain what to change in ReadMe file.

@rootulp rootulp self-assigned this Aug 27, 2023
@rootulp rootulp added this to the Post-mainnet milestone Aug 27, 2023
@rootulp rootulp mentioned this issue Aug 27, 2023
Merged
rootulp added a commit that referenced this issue Aug 28, 2023
@rootulp
docs: fix namespace rules in x/blob/README.md (#2368)
55f4360 
Closes #2350
mergify bot pushed a commit that referenced this issue Aug 28, 2023
@rootulp @mergify
docs: fix namespace rules in x/blob/README.md (#2368)
06ab661 
Closes #2350

(cherry picked from commit 55f4360)

# Conflicts:
#	x/blob/README.md
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
docs: fix namespace rules in x/blob/README.md (#2368)
f5ff333 
Closes celestiaorg/celestia-app#2350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix namespace rules in x/blob/README.md rootulp/celestia-app
2 participants
@rootulp @Vikramop