Skip to content

Commit

Permalink
fix: linter complains
Browse files Browse the repository at this point in the history
  • Loading branch information
mojtaba-esk committed Sep 12, 2024
1 parent 6a60da0 commit 8195717
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 11 deletions.
8 changes: 3 additions & 5 deletions test/e2e/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import (
"log"
"os"
"strings"

"github.com/celestiaorg/celestia-app/v3/test/e2e/testnet"
)

const (
Expand All @@ -22,11 +20,11 @@ type Test struct {
func main() {
logger := log.New(os.Stdout, "test-e2e", log.LstdFlags)

latestVersion, err := testnet.GetLatestVersion()
testnet.NoError("failed to get latest version", err)
// latestVersion, err := testnet.GetLatestVersion()
// testnet.NoError("failed to get latest version", err)

// TODO: remove me when the issue with bbr is fixed on k8s
latestVersion = "v2.1.2"
latestVersion := "v2.1.2"

logger.Println("Running major upgrade to v2 test", "version", latestVersion)

Expand Down
4 changes: 2 additions & 2 deletions test/e2e/minor_version_compatibility.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ func MinorVersionCompatibility(logger *log.Logger, _ string) error {
v := versions.Random(r).String()
logger.Println("Starting node", "node", i, "version", v)

testnet.NoError("failed to create genesis node",
testNet.CreateGenesisNode(ctx, v, 10000000, 0, testnet.DefaultResources, false))
testnet.NoError("failed to create genesis node",
testNet.CreateGenesisNode(ctx, v, 10000000, 0, testnet.DefaultResources, false))
}

logger.Println("Creating txsim")
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/simple.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ func E2ESimple(logger *log.Logger, appVersion string) error {
defer testNet.Cleanup(ctx)

logger.Println("Creating testnet validators")
testnet.NoError("failed to create genesis nodes",
testNet.CreateGenesisNodes(ctx, 4, appVersion, 10000000, 0, testnet.DefaultResources, true))
testnet.NoError("failed to create genesis nodes",
testNet.CreateGenesisNodes(ctx, 4, appVersion, 10000000, 0, testnet.DefaultResources, true))

logger.Println("Creating txsim")
endpoints, err := testNet.RemoteGRPCEndpoints(ctx)
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/testnet/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ func (n *Node) WaitUntilStartedAndCreateProxy(ctx context.Context) error {
return err
}

//TODO: It is recomended to use AddHostWithReadyCheck for the proxy
// TODO: It is recommended to use AddHostWithReadyCheck for the proxy
rpcProxyHost, err := n.Instance.Network().AddHost(ctx, rpcPort)
if err != nil {
return err
Expand All @@ -372,7 +372,7 @@ func (n *Node) WaitUntilStartedAndCreateProxy(ctx context.Context) error {
// }
// n.grpcProxyHost = grpcProxyHost

//TODO: It is recomended to use AddHostWithReadyCheck for the proxy
// TODO: It is recommended to use AddHostWithReadyCheck for the proxy
traceProxyHost, err := n.Instance.Network().AddHost(ctx, tracingPort)
if err != nil {
return err
Expand Down

0 comments on commit 8195717

Please sign in to comment.