Skip to content

Commit

Permalink
fix(txsim): resolves discrepancies between suggested and implemented …
Browse files Browse the repository at this point in the history
…flags (#2401)

## Overview

During the interaction with txsim, I noticed certain inconsistencies
between the suggested flags and the actual flags available in the
implementation. The purpose of this PR is to reconcile the two aspects
and ensure alignment.

Partially covers
#2383.

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
  • Loading branch information
staheri14 authored Sep 1, 2023
1 parent 480f2e8 commit 3ad4983
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions test/cmd/txsim/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ defined sequences; recursive patterns between one or more accounts which will co
transactions. You can use flags or environment variables (TXSIM_RPC, TXSIM_GRPC, TXSIM_SEED,
TXSIM_POLL, TXSIM_KEYPATH) to configure the client. The keyring provided should have at least one
well funded account that can act as the master account. The command runs until all sequences error.`,
Example: "txsim --key-path /path/to/keyring --rpc-endpoints localhost:26657 --grpc-endpoints localhost:9090 --seed 1234 --poll-time 1s --blob 5",
Example: "txsim --key-path /path/to/keyring --grpc-endpoint localhost:9090 --seed 1234 --poll-time 1s --blob 5",
RunE: func(cmd *cobra.Command, args []string) error {
var (
keys keyring.Keyring
Expand Down Expand Up @@ -94,7 +94,7 @@ well funded account that can act as the master account. The command runs until a
if grpcEndpoint == "" {
grpcEndpoint = os.Getenv(TxsimGRPC)
if grpcEndpoint == "" {
return errors.New("grpc endpoints not specified. Use --grpc-endpoints or TXSIM_GRPC env var")
return errors.New("grpc endpoints not specified. Use --grpc-endpoint or TXSIM_GRPC env var")
}
}

Expand Down
2 changes: 1 addition & 1 deletion test/txsim/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func Run(
return err
}

// Initiaize each of the sequences by allowing them to allocate accounts.
// Initialize each of the sequences by allowing them to allocate accounts.
for _, sequence := range sequences {
sequence.Init(ctx, manager.conn, manager.AllocateAccounts, r, opts.useFeeGrant)
}
Expand Down
4 changes: 2 additions & 2 deletions test/txsim/sequence.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ type Sequence interface {
Next(ctx context.Context, querier grpc.ClientConn, rand *rand.Rand) (Operation, error)
}

// An operation represents a series of messages and blobs that are to be bundled in a
// single transaction. A delay (in heights) may also be set before the transaction is sent.
// Operation represents a series of messages and blobs that are to be bundled
// in a single transaction. A delay (in heights) may also be set before the transaction is sent.
// The gas limit and price can also be set. If left at 0, the DefaultGasLimit will be used.
type Operation struct {
Msgs []types.Msg
Expand Down

0 comments on commit 3ad4983

Please sign in to comment.