addresses first round of comments

test/e2e/benchmark/benchmark.go

@@ -73,8 +73,7 @@ func (b *BenchmarkTest) SetupNodes() error {
 		if pushConfig, err := trace.GetPushConfigFromEnv(); err == nil {
 			log.Print("Setting up trace push config")
 			for _, node := range b.Nodes() {
-				if err = node.Instance.SetEnvironmentVariable(trace.
-					PushBucketName, pushConfig.BucketName); err != nil {
+				if err = node.Instance.SetEnvironmentVariable(trace.PushBucketName, pushConfig.BucketName); err != nil {
 					return fmt.Errorf("failed to set TRACE_PUSH_BUCKET_NAME: %v", err)
 				}
 				if err = node.Instance.SetEnvironmentVariable(trace.PushRegion, pushConfig.Region); err != nil {

test/e2e/benchmark/manifest.go

@@ -68,15 +68,13 @@ type Manifest struct {
 	// consensus parameters
 	MaxBlockBytes int64
 
-	// other configs
-	// tracing configs, can be local or noop
+	// LocalTracingType can be "local" or "noop"
 	LocalTracingType string
 	PushTrace        bool
 	// download traces from the s3 bucket
 	// only available when PushTrace is enabled
 	DownloadTraces bool
 
-	// other configs
 	UpgradeHeight    int64
 	GovMaxSquareSize int64
 }

test/e2e/testnet/node.go

@@ -50,9 +50,9 @@ type Node struct {
 }
 
 // PullRoundStateTraces retrieves the round state traces from a node.
-// it will save it to the provided path.
+// It will save them to the provided path.
 func (n *Node) PullRoundStateTraces(path string) ([]trace.Event[schema.
-	RoundState], error,
+RoundState], error,
 ) {
 	addr := n.AddressTracing()
 	log.Info().Str("Address", addr).Msg("Pulling round state traces")