Update cip-6.md title and add summary table #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the spirit of CIP-13, added a single-row table summarizing the new parameter. Would be good to set a standard to have this table in any CIP that introduces a new parameter so it can easily be copied into CIP-13 if/when it's approved. Also updated the title to be a bit more descriptive
Co-authored-by: Callum Waters <[email protected]>
jcstein
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of CIP-13, added a single-row table summarizing the new parameter.
Would be good to set a standard to have this table in any CIP that introduces a new parameter or modifies one so it can easily be copied into CIP-13 if/when it's approved.
In this vein it wasn't entirely clear to me what the param store will be called. This CIP mentions it will be a new param.Subspace but doesn't name it, so I'm optimistically calling it
gasbut feel free to correct. That said it's not clear to me why this shouldn't just go underauthalong with eg.auth.TxSizeCostPerByte?Also updated the title to be a bit more descriptive
Overview
Checklist