Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expand CIP4 with reference implementation #64

Merged
merged 5 commits into from
Feb 5, 2024
Merged

feat: expand CIP4 with reference implementation #64

merged 5 commits into from
Feb 5, 2024

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Feb 5, 2024

Overview

  • expands reference implementation with details for sampling window for light nodes
  • explains options for storage pruning
  • updates CIP author
  • updates link to PR for upcoming pruning PR in celestia-node in CIP preamble

jcstein
jcstein reviewed Feb 5, 2024
View reviewed changes
cips/cip-4.md Outdated Show resolved Hide resolved
jcstein
jcstein reviewed Feb 5, 2024
View reviewed changes
cips/cip-4.md Outdated Show resolved Hide resolved
jcstein
jcstein reviewed Feb 5, 2024
View reviewed changes
cips/cip-4.md Outdated Show resolved Hide resolved
jcstein
jcstein requested changes Feb 5, 2024
View reviewed changes
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left minor styling edits

cips/cip-4.md Outdated Show resolved Hide resolved
ramin and others added 4 commits February 5, 2024 16:03
@ramin @jcstein
Update cips/cip-4.md
2be50b4 
Co-authored-by: Josh Stein <[email protected]>
@ramin @jcstein
Update cips/cip-4.md
9df2d25 
Co-authored-by: Josh Stein <[email protected]>
@ramin @jcstein
Update cips/cip-4.md
87142dd 
Co-authored-by: Josh Stein <[email protected]>
@ramin @jcstein
Update cips/cip-4.md
837baf7 
Co-authored-by: Josh Stein <[email protected]>
@ramin ramin requested a review from jcstein February 5, 2024 16:04
@jcstein jcstein merged commit a647abf into celestiaorg:main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YazzyYaz YazzyYaz YazzyYaz approved these changes

@jcstein jcstein jcstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramin @YazzyYaz @jcstein