Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move CIPs 26,27,28 to Review #228

Merged
merged 1 commit into from
Oct 21, 2024
Merged

docs: move CIPs 26,27,28 to Review #228

merged 1 commit into from
Oct 21, 2024

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Oct 19, 2024

Overview

rootulp
rootulp approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIP-27 and CIP-28 don't have test cases but it looks like that's optional per

CIPs/cips/cip-1.md

Lines 287 to 291 in 0cf3a6f

* **Test Cases (optional)**: Test cases are mandatory for CIPs affecting
consensus changes. They should either be inlined in the CIP as data (such
as input/expected output pairs) or included in `../assets/cip-###/<filename>`.
This section can be omitted for non-Core proposals.
* **Reference Implementation (optional)**: This optional section contains
so LGTM.

@jcstein jcstein merged commit b532fc5 into main Oct 21, 2024
5 checks passed
@jcstein jcstein deleted the jcs/reviews branch October 21, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees

@jcstein jcstein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcstein @rootulp