move cip 21 into last call

[cmwaters]

No description provided.

[rootulp]

The reference implementation still needs to be filled out

[jcstein]

• Add reference implementation
• Add last call deadline
  +1 to @rootulp's review

[rootulp]

[question] can this feature be used with feegrant? If yes, and we have:

1. celestiaA agrees to pay gas for all message for celestiaB
2. celestiaB submits an authored blob and uses gas from celestiaA.
3. Whose address goes in the signer field?

If it's celestiaB then should we stop using the term "that paid for this blob" and instead use something like:

// Signer is sdk.AccAddress that submitted this blob.

[jcstein]

good catch!

[jcstein]

After reading through this CIP again recently, I'm a little confused how this would handle blobs submitted with feegrant as described in this thread. cc: @cmwaters as well for review

[jcstein]

Suggested change

	+ // Signer is sdk.AccAddress that paid for this blob. This field is optional
	+ // Signer is sdk.AccAddress that signed this blob. This field is optional

[jcstein]

So even though the fee granter paid for the blob to be included on-chain, the MsgPayForBlobs submitter (celestia1rgj3z5rfydj3xulhm6glqr0zs7j8rr9rfh6ekw) is the authored blob "signer".

@rootulp - So in this case shouldn't it be // Signer is sdk.AccAddress that signed this blob?

[rootulp]

Callum is OOO, maybe we should merge this as-is and we can edit it after the fact if that comment about "paid for" vs "submitted" is confusing for anyone else.

cc: @jcstein thoughts?

[jcstein]

I think we can implement this feedback after it's in Last Call. However, here's some food for thought:

IIRC, the fee Granter/Payer account does not show any messages when blobs are posted. So If I had blob X with Grantee/Signer A and Granter/Payer B, it would only show on chain for Grantee/Signer A

Account	Tx	Message on explorer?
A: Grantee/Signer	PayForBlobs	Yes
B: Granter/Payer	PayForBlobs from "A: Grantee/Signer"	No, see transactions and messages tabs
B: Granter/Payer	FeeGrant	Yes

Accounts used in demo:
A: Grantee/Signer: celestia1rgj3z5rfydj3xulhm6glqr0zs7j8rr9rfh6ekw on Mocha
B: Granter/Payer: celestia1sung806mz9r4lwdpaw6usk7hcw42ku7kyun44w on Mocha

[rootulp]

Thanks for the links! That seems like expected behavior because the fee granter didn't submit a MsgPayForBlobs in this example. So even though the fee granter paid for the blob to be included on-chain, the MsgPayForBlobs submitter (celestia1rgj3z5rfydj3xulhm6glqr0zs7j8rr9rfh6ekw) is the authored blob "signer".

Callum addressed blocking feedback.