-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move cip-24 to review #208
Merged
rootulp
merged 4 commits into
celestiaorg:main
from
ninabarbakadze:nina/move-cip24-to-review
Sep 24, 2024
Merged
chore: move cip-24 to review #208
rootulp
merged 4 commits into
celestiaorg:main
from
ninabarbakadze:nina/move-cip24-to-review
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
reviewed
Sep 20, 2024
@@ -4,7 +4,7 @@ | |||
| description | Transition to hard fork-only updates for gas scheduler variables | | |||
| author | Nina Barbakadze ([@ninabarbakadze](https://github.com/ninabarbakadze)) | | |||
| discussions-to | <https://forum.celestia.org/t/cip-versioned-gas-scheduler-variables/1785> | | |||
| status | Draft | | |||
| status | Review | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference implementation section needs to be filled out.
jcstein
approved these changes
Sep 24, 2024
rootulp
approved these changes
Sep 24, 2024
ninabarbakadze
commented
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge? @jcstein
yup was just waiting on another review 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Moving cip-24 to status - Review