Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to markdownlint-cli v0.35.0 #69

Merged
merged 1 commit into from
Aug 4, 2023
Merged

chore: upgrade to markdownlint-cli v0.35.0 #69

merged 1 commit into from
Aug 4, 2023

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Aug 4, 2023 •
edited
Loading

Attempt to resolve celestiaorg/celestia-app#2212 by upgrading markdownlint-cli to the latest release: v0.35.0

cc: @sweexordious

@rootulp rootulp requested review from MSevey and a team as code owners August 4, 2023 14:02
@rootulp rootulp self-assigned this Aug 4, 2023
@rootulp rootulp added the dependencies Pull requests that update a dependency file label Aug 4, 2023
@rootulp rootulp enabled auto-merge (squash) August 4, 2023 14:13
rach-id
rach-id reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test if working?

@rootulp
Copy link
Contributor Author

rootulp commented Aug 4, 2023 •
edited
Loading

Yea I just tested locally but I don't expect this to resolve. I tested your PR with markdownlint-cli v0.32.1 and v0.35.0 installed and they both report the same errors:

$ make lint
--> Running golangci-lint
--> Running markdownlint
specs/src/specs/namespace.md:65 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Primary Reserved Namespaces:..."]
specs/src/specs/namespace.md:87 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Implementation"]

rach-id
rach-id approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its good to bump versions anyway, let's merge

@rootulp rootulp merged commit bdde53d into main Aug 4, 2023
8 checks passed
@rootulp rootulp deleted the rp/bump-markdownlint-cli branch August 4, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuu smuu smuu approved these changes

@rach-id rach-id rach-id approved these changes

@MSevey MSevey Awaiting requested review from MSevey MSevey is a code owner

Assignees

@rootulp rootulp

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown lint CI not failing on non-respected rules
3 participants
@rootulp @smuu @rach-id