Cycle through host before calling errback #2331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In oslo.messaging error callback (named _recoverable_error_callback), the code is raising an TimeoutError, which is preventing continuation of the retry in some situation. This quick fix switch the selection of next host (cycle) before calling the error callback. Then, on next ensure_connection, the new host is selected and we expect it to work correctly :) See: lp-2096926 Signed-off-by: Arnaud Morin <[email protected]>
auvipy
requested changes
Jul 8, 2025
|
what about merging the changes of 2 separate pr in a single one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In oslo.messaging error callback (named _recoverable_error_callback), the code is raising an TimeoutError, which is preventing continuation of the retry in some situation.
This quick fix switch the selection of next host (cycle) before calling the error callback. Then, on next ensure_connection, the new host is selected and we expect it to work correctly :)
See: lp-2096926