-
-
Couldn't load subscription status.
- Fork 969
Virtual transport of RocketMQ #2306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please also fix the failing test
=================================== FAILURES ===================================
____________________________ test_Channel.test_get _____________________________
self = <t.unit.transport.test_rocketmq.test_Channel object at 0x7f75eb63bbf0>
def test_get(self):
queue = 'new-queue'
self.channel.basic_consume(queue, True, None, 'cg1')
self.consumer.receive.return_value = []
with pytest.raises(Empty):
self.channel._get(queue)
rocketmq_message = _message_to_rocketmq_ack_message(_mock_message(topic=queue, queue=queue))
rocketmq_message.body = str_to_bytes(dumps(self.channel.prepare_message({})))
t/unit/transport/test_rocketmq.py:150:
self = <rocketmq.v5.model.message.Message object at 0x7f75d9132c00>
body = b'{"body": {}, "content-encoding": null, "content-type": null, "headers": {}, "properties": {"delivery_info": {}, "priority": 0}}'
Restoring 2 unacknowledged message(s)
@body.setter
def body(self, body):
if body is None or body.strip() == "":
E BytesWarning: Comparison between bytes and string
.tox/3.12-unit/lib/python3.12/site-packages/rocketmq/v5/model/message.py:175: BytesWarning
for more information, see https://pre-commit.ci
hi, I've suppressed the BytesWarning for those test cases, and I'll submit an issue to the SDK community to get it fixed. |
|
Ok, thanks |
|
@auvipy hi, I've fixed the issue which causes test failure in py313, could you help me trigger the workflow? |
|
Sure |
#2305
Add virtual transport for RocketMQ