Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide annotations for kombu/utils/encoding.py #2208

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Harry-Lees
Copy link

Linked Issue: #1511

For this PR, I aimed to annotate the existing implementation of the encoding functions, regardless of what I thought the function's intention is.

There are some functions e.g. str_to_bytes, bytes_to_str, or safe_str which I think may have potentially misleading implementations. I'm not sure whether this is under the scope of this PR, input on this would be appreciated :).

Harry-Lees and others added 4 commits December 20, 2024 14:32
The initial annotations provided aim to annotate the current implementation opposed
to potentially refactoring to narrow down the original intention of the provided
implementations.
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.48%. Comparing base (6363d64) to head (4f51694).

Files with missing lines Patch % Lines
kombu/utils/encoding.py 81.81% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2208      +/-   ##
==========================================
- Coverage   81.50%   81.48%   -0.03%     
==========================================
  Files          77       77              
  Lines        9522     9532      +10     
  Branches     1151     1155       +4     
==========================================
+ Hits         7761     7767       +6     
  Misses       1569     1569              
- Partials      192      196       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy auvipy self-requested a review December 22, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant