Skip to content

When automatically disables task, remeber to set no_changes = False #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tdybda17
Copy link

No description provided.

@auvipy auvipy requested review from Copilot and auvipy and removed request for Copilot May 12, 2025 05:59
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change will also need some unit tests to verify it and to avoid any regression

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (d78ba7a) to head (236036a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
+ Coverage   87.62%   87.94%   +0.32%     
==========================================
  Files          32       32              
  Lines        1010     1012       +2     
  Branches       81      104      +23     
==========================================
+ Hits          885      890       +5     
+ Misses        107      104       -3     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cclauss
Copy link
Contributor

cclauss commented May 12, 2025

pre-commit failures:

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

django_celery_beat/schedulers.py:381:80: E501 line too long (121 > 79 characters)
t/unit/test_schedulers.py:1459:1: E303 too many blank lines (3)
t/unit/test_schedulers.py:1469:80: E501 line too long (80 > 79 characters)
t/unit/test_schedulers.py:1473:80: E501 line too long (84 > 79 characters)
t/unit/test_schedulers.py:1494:80: E501 line too long (84 > 79 characters)

@cclauss
Copy link
Contributor

cclauss commented May 12, 2025

Please rebase to fix the linter failure.

@auvipy
Copy link
Member

auvipy commented May 18, 2025

@alirafiei75 can you check this locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants