Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Alert messages #179

Closed
wants to merge 4 commits into from
Closed

Alert messages #179

wants to merge 4 commits into from

Conversation

digilou
Copy link

@digilou digilou commented Oct 12, 2017

Closes #176

  • dialog box structure created using semantic HTML and ARIA
  • styling with appropriate color contrast created
  • JS close functionality created

One issue:

  • I'm struggling with closing the modal via the Esc key. My code "seems" right, but it's not working (at least not on CodePen).

Also, I'm more than happy to receive some critique, in case I've missed something that's an obvious accessibility faux pas. Making these patterns available to all is amazing and important work.

Example available on CodePen: https://codepen.io/digilou/pen/XeBrGV

@scottaohara @cehfisher ready for review.

@cehfisher
Copy link
Owner

@digilou I think some more work is needed on this component, so I've been struggling with how to address this PR. let's head back to the ticket #176 and discuss

@cehfisher cehfisher closed this Dec 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build accessible alert message pattern
2 participants