Skip to content

fix(web): simplify Helmet imports to use named ESM exports #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tobbe merged 2 commits into from
Mar 27, 2026
Merged

fix(web): simplify Helmet imports to use named ESM exports #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c745fe8
refactor: simplify Helmet imports to use named ESM exports
mvanhorn Mar 27, 2026
52acb94
style: add blank line between import groups in MetaTags
mvanhorn Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/web/src/components/MetaTags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import React from 'react'

import * as helmetPkg from '@dr.pogodin/react-helmet'
import { Helmet as HelmetHead } from '@dr.pogodin/react-helmet'

const { Helmet: HelmetHead } = helmetPkg
// Ideally we wouldn't include this for non experiment builds
// But.... not worth the effort to remove it from bundle atm
import PortalHead from './PortalHead.js'
Expand Down
4 changes: 1 addition & 3 deletions packages/web/src/components/Metadata.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@

import React from 'react'

import * as helmetPkg from '@dr.pogodin/react-helmet'

const { Helmet: HelmetHead } = helmetPkg
import { Helmet as HelmetHead } from '@dr.pogodin/react-helmet'

// Ideally we wouldn't include this for non experiment builds
// But.... not worth the effort to remove it from bundle atm
Expand Down
3 changes: 1 addition & 2 deletions packages/web/src/components/RedwoodProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import React from 'react'

// @NOTE: Helmet is not used in SSR & RSC
import * as helmetPkg from '@dr.pogodin/react-helmet'
const { Helmet, HelmetProvider } = helmetPkg
import { Helmet, HelmetProvider } from '@dr.pogodin/react-helmet'

interface RedwoodProviderProps {
children: React.ReactNode
Expand Down
4 changes: 1 addition & 3 deletions packages/web/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ export * from './components/RedwoodProvider.js'

export * from './components/MetaTags.js'
export * from './components/Metadata.js'
import * as helmetPkg from '@dr.pogodin/react-helmet'

const { Helmet } = helmetPkg
import { Helmet } from '@dr.pogodin/react-helmet'
export { Helmet as Head, Helmet }

export * from './components/htmlTags.js'
Expand Down
Loading