backport 64bit patches from qemu #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,7 +271,7 @@ int udp_output2(struct socket *so, struct mbuf *m, | |||
| * and addresses and length put into network format. | |||
| */ | |||
| ui = mtod(m, struct udpiphdr *); | |||
| ui->ui_next = ui->ui_prev = 0; | |||
| memset(&ui->ui_i.ih_mbuf, 0 , sizeof(struct mbuf_ptr)); | |||
There was a problem hiding this comment.
Indentation seems wrong here. Is it the same upstream?
|
Thanks for doing this, just a few comments about indentation... |
|
I confirm this patch fixes #27 on Debian Jessie amd64. |
|
If it does resolve 64bit problem in slirp, that's a lot of typing get wasted without mergin. What a pity! |
|
There were formatting issues and I missed to follow that up. The code itself should be OK and in production use.
KR
… Am 01.11.2017 um 17:03 schrieb Timofonic ***@***.***>:
@asvitkine @clehner @rickyzhang82 @krechert Has this been merged upstream? If not: Why not?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #27