Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: planetary name resolvers (openstreetmap and gazetteer of planetary features) #103

Merged
merged 17 commits into from
Sep 16, 2024
Merged

feat: planetary name resolvers (openstreetmap and gazetteer of planetary features) #103

merged 17 commits into from
Sep 16, 2024

Commits on Sep 13, 2024

  1. feat: Add support for planetary body objects for target property

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8892606 View commit details
    Browse the repository at this point in the history

  2. 🐛 Add error when target object is unknown

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    fbdbc2f View commit details
    Browse the repository at this point in the history

  3. ✅ Add tests for planetary coordinates

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    15fcc70 View commit details
    Browse the repository at this point in the history

  4. 📝 Update changelog

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bb42726 View commit details
    Browse the repository at this point in the history

  5. 🥅 Improve error management with new '_ready' traitlets

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    99cea01 View commit details
    Browse the repository at this point in the history

  6. 🎨 Replace 200 constant by requests value

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b4fc78d View commit details
    Browse the repository at this point in the history

  7. 🎨 Make target property return BaseBodycentricRepresentation when surv… 

    …ey body is a planetary body
    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5b77b84 View commit details
    Browse the repository at this point in the history

  8. docs: Add warning when planetary body fetching is not returning the s… 

    …ame object as expected
    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    68af7de View commit details
    Browse the repository at this point in the history

  9. 🐛 Try fixing planetary coordinate as target

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    016182f View commit details
    Browse the repository at this point in the history

  10. ✨ Allow target setting using a tuple of two floats

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b02f007 View commit details
    Browse the repository at this point in the history

  11. 🚑 Fix missing line because of rebase

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    67dbab4 View commit details
    Browse the repository at this point in the history

  12. ✅ Fix tests

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d81d0e9 View commit details
    Browse the repository at this point in the history

  13. 🚑 Fix un-raised NameResolveError and improve comments

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0fad84d View commit details
    Browse the repository at this point in the history

  14. 📝 Add new notebook 12 to show how to use ipyaladin with planetary body

    @Xen0Xys @ManonMarchand
    Xen0Xys authored and ManonMarchand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    91f5706 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. feat: add support for earth, return longitude and latitude objects in… 

    …stead of floats
    @ManonMarchand
    ManonMarchand committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1079336 View commit details
    Browse the repository at this point in the history

  2. docs: document name resolvers

    @ManonMarchand
    ManonMarchand committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9abd11e View commit details
    Browse the repository at this point in the history

  3. fix: make tests pass

    @ManonMarchand
    ManonMarchand committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c9b530a View commit details
    Browse the repository at this point in the history