watchdog: Reset timer instead of writing fan level to avoid spinup#33
Merged
watchdog: Reset timer instead of writing fan level to avoid spinup#33
Conversation
On certain ThinkPad models like the E14 and T495, setting level 0 again when already at level 0 briefly spins up the fans. To avoid this, change the behaviour to write the watchdog timeout when we are close to expiration rather than setting the level again. Closes #32. Also see vmatare/thinkfan#114.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On certain ThinkPad models like the E14 and T495, setting level 0 again when already at level 0 briefly spins up the fans.
To avoid this, change the behaviour to write the watchdog timeout when we are close to expiration rather than setting the level again.
Closes #32. Also see vmatare/thinkfan#114.