Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the library so that it compiles on stable Rust #3

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

MortenLohne
Copy link

Thanks for this library! I found it quite interesting, especially Takkerus. Unfortunately, it no longer compiles on recent Rust versions, neither nightly nor stable. This PR makes the project compile with no warnings on the stable compiler, and allows Takkerus to do so as well.

You don't have to pull this as-is, as I had to make some sacrifices. In particular:

  • I removed the benchmarks from the tests directory, as they aren't available in stable Rust, and probably never will be. They could be re-added using an external crate.
  • The with_tak_ann feature does not compile. It seems to have relied on old nightly features, that are no longer available even on current nightly. I decided to simply leave it, as Takkerus doesn't rely on it.

Otherwise, I didn't have to make many changes, the PR is much smaller than it looks. I basically:

  • Removed #![feature(test)], so that it runs on stable
  • Fixed all try!and dyn warnings
  • Updated dependencies. This required some small changes to JKiss32Rng
  • Bumped version to 1.3

It seems to be impossible for the search to run without them. They are small dependencies anyway, so simplest solution seems to be to always include them
They could be re-added with a benchmarking library
This is probably necessary, since the project now requires a more modern version of the compiler, and relies on newer dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant