Modernize the library so that it compiles on stable Rust #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this library! I found it quite interesting, especially Takkerus. Unfortunately, it no longer compiles on recent Rust versions, neither nightly nor stable. This PR makes the project compile with no warnings on the stable compiler, and allows Takkerus to do so as well.
You don't have to pull this as-is, as I had to make some sacrifices. In particular:
with_tak_ann
feature does not compile. It seems to have relied on old nightly features, that are no longer available even on current nightly. I decided to simply leave it, as Takkerus doesn't rely on it.Otherwise, I didn't have to make many changes, the PR is much smaller than it looks. I basically:
#![feature(test)]
, so that it runs on stabletry!
anddyn
warningsJKiss32Rng