Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ methods for applying operations to DDs #674

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

burgholzer
Copy link
Member

Description

This PR adds a couple of convenience methods for applying operations to DDs.
This avoids having to duplicate the respective logic in top-level libraries like DDSIM or QCEC.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Aug 19, 2024
@burgholzer burgholzer added enhancement New feature or request usability Anything related to usability DD Anything related to the DD package c++ Anything related to C++ code labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 83.13253% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.9%. Comparing base (9be9167) to head (7860cb8).

Files Patch % Lines
include/mqt-core/dd/Operations.hpp 74.5% 13 Missing ⚠️
include/mqt-core/dd/Package.hpp 92.3% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #674     +/-   ##
=======================================
+ Coverage   87.0%   91.9%   +4.8%     
=======================================
  Files        125     125             
  Lines      13780   13833     +53     
  Branches    2164    2171      +7     
=======================================
+ Hits       11997   12717    +720     
+ Misses      1783    1116    -667     
Flag Coverage Δ
cpp 91.6% <83.1%> (+5.0%) ⬆️
python 99.7% <ø> (ø)
Files Coverage Δ
include/mqt-core/dd/Simulation.hpp 100.0% <100.0%> (ø)
...-core/ir/operations/ClassicControlledOperation.hpp 96.7% <100.0%> (+<0.1%) ⬆️
src/dd/FunctionalityConstruction.cpp 94.8% <100.0%> (+70.6%) ⬆️
src/dd/Simulation.cpp 96.0% <100.0%> (+96.0%) ⬆️
include/mqt-core/dd/Package.hpp 97.0% <92.3%> (+1.3%) ⬆️
include/mqt-core/dd/Operations.hpp 85.4% <74.5%> (-2.7%) ⬇️

... and 17 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code DD Anything related to the DD package enhancement New feature or request usability Anything related to usability
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant