Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First iteration of the dashboard (version 2) #46

Open
wants to merge 1 commit into
base: dashboard-v2
Choose a base branch
from

Conversation

kbelisar
Copy link
Collaborator

@kbelisar kbelisar commented Nov 2, 2022

Basic structure is there with easy-to-navigate tabs at the top of the page - one tab for each data type. Still require a few items to attend to prior to making public, which will be updated in #41.

Basic structure is there with easy-to-navigate tabs at the top of the page - one tab for each data type. Still require a few items to attend to prior to making public, which will be updated in #41.
Copy link
Member

@jeanpaulrsoucy jeanpaulrsoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! A few thoughts:

  • I noticed that the hover values break for the whole plot if any of the legend filters are applied (e.g., turn off SK from the first facet of the wastewater plot and hover values break for the whole plot)
  • Is it possible to censor data points when there is no/incomplete data? This applies across several plots. For example, on the deaths plot, a lot of deaths seem to to go zero in the most recent week, but I think this reflects missing data. Empty weeks should be censored (and this may differ across provinces), or else all weeks should be censored to the most recent common time with data (often the previous Saturday or Saturday before that - a lot of places report data according to epi weeks).
  • The weighting of wastewater data should be explicit somehow (e.g., SK is an unweighted average of the SK sites, Toronto is an unweighted average of the Toronto sites...).
  • Regarding converting to weeks, I believe the typical scheme is to start the first week on the first Sunday of the year. Thus the final epi week of the year typically includes a few days from the subsequent year. This is fine if you are using a date to indicate "the week of...". This could eliminate the issue of splitting or otherwise dealing with week 53, if we think of it in terms of "the week of" rather than years.
  • Related to the above, the grouping of weeks should be explicit. Does the date refer to "the week beginning" or "the week ending"?
  • The logo in the top left corner isn't loading for me. It appears to be in the www directory but trying to load from the root directory?
  • The colours of the wastewater plot can be a little hard to distinguish from each other. For example, in the Western region, SK stands out but AB and BC look pretty similar to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants