Fix form issues on goal forms #127
Merged
+138
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pagetree's auto-generated <form> tag has a few problems preventing me from using it with the goal forms: * After submitting an invalid form, Pagetree's Submit button disappears, preventing the user from being able to submit the form again. * The "change my answers" form isn't compatible with formsets. See ccnmtl/django-pagetree#58 My solution is to again have the pageblock render its own <form>. This necessitates an unfortunate hack: hiding pagetree's Submit button with JavaScript. This is one of the reasons I think needs_submit should be broken out into two different configurable params: Something like `handles_post_data` and `renders_form`. Related to issue here: ccnmtl/django-pagetree#44
djredhand
pushed a commit
that referenced
this pull request
Mar 12, 2015
Fix form issues on goal forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pagetree's auto-generated
<form>tag has a few problems preventingme from using it with the goal forms:
preventing the user from being able to submit the form again.
Need a scheme for integrating formsets with pagetree's form handling django-pagetree#58
My solution is to again have the pageblock render its own
<form>. Thisnecessitates an unfortunate hack: hiding pagetree's Submit button with
JavaScript. This is one of the reasons I think needs_submit should be
broken out into two different configurable params: Something like
handles_post_dataandrenders_form. Related to issue here:ccnmtl/django-pagetree#44