Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if stdin is terminal #59

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

ccbrown
Copy link
Owner

@ccbrown ccbrown commented Jan 8, 2025

What It Does

Calling crossterm::terminal::supports_keyboard_enhancement() causes a hang when stdin isn't a terminal. This checks to see if stdin is a terminal first.

Related Issues

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (e98418d) to head (14af000).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/iocraft/src/terminal.rs 20.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   91.44%   91.34%   -0.10%     
==========================================
  Files          24       24              
  Lines        3588     3593       +5     
  Branches     3588     3593       +5     
==========================================
+ Hits         3281     3282       +1     
- Misses        237      241       +4     
  Partials       70       70              
Files with missing lines Coverage Δ
packages/iocraft/src/terminal.rs 71.59% <20.00%> (-1.03%) ⬇️

Impacted file tree graph

@ccbrown ccbrown merged commit c8b15ae into main Jan 8, 2025
4 of 5 checks passed
@ccbrown ccbrown deleted the check-if-stdin-is-terminal branch January 8, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant