Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename Box to View to avoid conflict #56

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat!: rename Box to View to avoid conflict #56

merged 1 commit into from
Dec 30, 2024

Conversation

ccbrown
Copy link
Owner

@ccbrown ccbrown commented Dec 30, 2024

What It Does

Renames Box to View to avoid conflict with std::boxed::Box.

Related Issues

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.44%. Comparing base (ffc6d12) to head (dd1b3e9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/iocraft/src/components/button.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files          24       24           
  Lines        3588     3588           
  Branches     3588     3588           
=======================================
  Hits         3281     3281           
  Misses        237      237           
  Partials       70       70           
Files with missing lines Coverage Δ
packages/iocraft-macros/src/lib.rs 95.72% <ø> (ø)
...ackages/iocraft/src/components/context_provider.rs 98.00% <ø> (ø)
packages/iocraft/src/components/text.rs 99.16% <100.00%> (ø)
packages/iocraft/src/components/text_input.rs 90.24% <ø> (ø)
packages/iocraft/src/components/view.rs 95.88% <100.00%> (ø)
packages/iocraft/src/element.rs 69.79% <100.00%> (ø)
packages/iocraft/src/hooks/use_async_handler.rs 93.02% <100.00%> (ø)
packages/iocraft/src/hooks/use_context.rs 100.00% <ø> (ø)
packages/iocraft/src/hooks/use_output.rs 93.02% <100.00%> (ø)
packages/iocraft/src/hooks/use_terminal_events.rs 96.66% <100.00%> (ø)
... and 2 more

Impacted file tree graph

@ccbrown ccbrown merged commit 2813e79 into main Dec 30, 2024
5 checks passed
@ccbrown ccbrown deleted the rename-box branch December 30, 2024 20:26
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant