Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable "std" feature for taffy #35

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

frnsys
Copy link
Contributor

@frnsys frnsys commented Dec 4, 2024

What It Does

I was trying to print out a table but my program would panic with the error called Result::unwrap()on anErr value: CapacityError: insufficient capacity. This was due to that if taffy does not have its alloc or std features enabled then it uses arrays with a maximum capacity, which limits e.g. in my case the number of children a node can have. It didn't seem to me that the std feature was intentionally excluded so I added it in.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.14%. Comparing base (534d705) to head (f56fda4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          23       23           
  Lines        3445     3445           
  Branches     3445     3445           
=======================================
  Hits         3140     3140           
  Misses        238      238           
  Partials       67       67           

Impacted file tree graph

@ccbrown
Copy link
Owner

ccbrown commented Dec 5, 2024

Thanks! std was excluded simply because it didn't seem necessary, but I hadn't encountered or considered this limitation.

I'll go ahead and cut a bug fix release with this change.

@ccbrown ccbrown merged commit d1038d1 into ccbrown:main Dec 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants