Feature requests

[milesj]

Just going to note all my requests/ideas here:

1) Rename Box to View

Self-explanatory. Just collides with Rust native Box.

2) Support a Handler with a return value

I'm working on form/input components and I'm adding a validate function kind of prop, which works. https://github.com/moonrepo/starbase/blob/console/crates/console/src/components/input.rs#L13

However, I had to basically copy all of the Handler code to make it work, as I needed a return type of Option<String> (invalid with error message or valid). https://github.com/moonrepo/starbase/blob/console/crates/console/src/components/mod.rs#L29

Would be nice to have a built-in type for a handler with a return function. Adding it to the existing Handler may be too much, as we would then need to return () everywhere or something. So a new type maybe best.

3) Prop type that can be a String or AnyElement

I've found myself needing this pattern a lot just for convenience. Basically I want something like this:

struct ExampleProps {
  label: StringOrElement
}

So that when we're rendering, we can use a simple string (which would just render Text under the hood):

Example(label: &some_string_value)

Or we can customize with a specific element:

Example(label: element!(CustomLabel).into_any())

[milesj]

4) render_loop without ANSI

It looks like render_loop always renders with ANSI, even when in CI and non TTY environments, as seen here: https://github.com/moonrepo/proto/actions/runs/12342638090/job/34442711429?pr=671 Would be nice if this was turned off.

[ccbrown]

4) render_loop without ANSI

It looks like render_loop always renders with ANSI, even when in CI and non TTY environments, as seen here: https://github.com/moonrepo/proto/actions/runs/12342638090/job/34442711429?pr=671 Would be nice if this was turned off.

The trick here is that render_loop can't function correctly without using ANSI sequences to erase prior output. A way to disable colors / text attributes would be reasonable though.

Also, for testing purposes, mock_terminal_render_loop might meet your needs – it allows you to get output as a sequence of Canvass which you can then print or turn into a string without ANSI codes.

[milesj]

Yeah that makes sense. Was mainly referring to all the color related sequences.

[milesj]

5) Support non-primitive values in use_state

I have a situation where I want to use a HashSet in state, but I have no way of inserting a value into the set after it's created. get requires Copy, which sets aren't, while read is immutable. The modify function would work, but it's not public.

[ccbrown]

5) Support non-primitive values in use_state

I have a situation where I want to use a HashSet in state, but I have no way of inserting a value into the set after it's created. get requires Copy, which sets aren't, while read is immutable. The modify function would work, but it's not public.

I just added a write function in #45 (merged to main). Give that a try and let me know if that suits your needs. With that, you should be able to do something like my_state.write().insert(foo).

Thanks as always for the excellent feedback!

[milesj]

Yeah that worked. Thanks for the quick turn around.

I did encounter another bug though. It looks like ExtendWithElements::extend collides with the native vec/map/set extend. May need to rename that method.