sameold,samedec: drop SignificanceLevel::Message #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SignificanceLevel::Message` is not part of NWSI 10-1712 or any other known standard, and very few event codes in sameold ever implement it. Discontinue this enum variant. The following event codes are affected and are upgraded to `Statement`s: * ADR Administrative Message * NMN Network Message Notification This is an API-BREAKING change. The samedec CLI is unaffected, but it is removed from the documentation.
cbs228
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SignificanceLevel::Messageis not part of NWSI 10-1712 or any other known standard, and very few event codes in sameold ever implement it.Discontinue this enum variant.
The following event codes are affected and are upgraded to
Statements:This is an API-BREAKING change. The samedec CLI is unaffected, but it is removed from the documentation.