samedec: flush on EOF in main app #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `samedec::app::run()` would unceremoniously exit on EOF. Since an EOF results in samples being "stranded" in filter buffers and other parts of the system, it is necessary to push zeros through the system to make it output any remaining Messages. This "flush" operation was performed by isolated code that ran after the app terminated. This would print the Message(s), but it would not take any other actions like spawning child processes. We should spawn the child even if there's no audio data that follows. The state machine will simply `wait()` for it to terminate and then exit. This change permits us to run child processes on short snippets of SAME data—i.e., our `sample/*.bin` data files. This is CLI-expanding behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
samedec::app::run()would unceremoniously exit on EOF. Since an EOF results in samples being "stranded" in filter buffers and other parts of the system, it is necessary to push zeros through the system to make it output any remaining Messages.This "flush" operation was performed by isolated code that ran after the app terminated. This would print the Message(s), but it would not take any other actions like spawning child processes.
We should spawn the child even if there's no audio data that follows. The state machine will simply
wait()for it to terminate and then exit.This change permits us to run child processes on short snippets of SAME data—i.e., our
sample/*.bindata files.This is CLI-expanding behavior.