Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Set Montage dialog view #459

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Change Set Montage dialog view #459

merged 7 commits into from
Dec 9, 2024

Conversation

bkloeckl
Copy link
Contributor

@bkloeckl bkloeckl commented Dec 6, 2024

To resolve Issue #253 while also enhancing the user experience, the preview of the selected channel montage should be embedded within the same window, rather than opening in a new window.

@cbrnr
Copy link
Owner

cbrnr commented Dec 6, 2024

Nice! I have some cosmetic suggestions:

Screenshot 2024-12-06 at 14 04 15

Also, I think there should be a minimal width of the preview plot.

@bkloeckl
Copy link
Contributor Author

bkloeckl commented Dec 6, 2024

Nice! I have some cosmetic suggestions:
Also, I think there should be a minimal width of the preview plot.

Aligned the figure correctly, removed the padding, added automatic stretching and min-width and min-height. However I would not place the buttons on the bottom-right corner as they would appear "lost" there. In my opinion they fit way better to the other control elements also for usability purposes. Let me know, what you think about the updated version.

@cbrnr
Copy link
Owner

cbrnr commented Dec 6, 2024

However I would not place the buttons on the bottom-right corner as they would appear "lost" there. In my opinion they fit way better to the other control elements also for usability purposes. Let me know, what you think about the updated version.

Yes, but I actually have plans for this bottom row, because I would like to add additional buttons in the future (e.g., "Read custom montage file..."). Can you show how this would look like now (with only the OK/Cancel buttons in the bottom row) so that we can have a visual comparison?

@cbrnr cbrnr changed the title Change Set-Montage Dialoge view Change Set-Montage dialog view Dec 6, 2024
@cbrnr cbrnr changed the title Change Set-Montage dialog view Change Set Montage dialog view Dec 6, 2024
@cbrnr cbrnr merged commit 73c07ee into cbrnr:main Dec 9, 2024
6 checks passed
@cbrnr
Copy link
Owner

cbrnr commented Dec 9, 2024

Thanks @bkloeckl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Montage previews cannot be closed on macOS
2 participants